From 9ec69d7149550fa7d448c71c17a268a69a6911b0 Mon Sep 17 00:00:00 2001 From: ireic Date: Wed, 29 Jan 2020 03:24:46 +0100 Subject: [PATCH 1/3] Added contributing guidelines --- CONTRIBUTING.md | 1 + README.md | 4 ++++ 2 files changed, 5 insertions(+) create mode 100644 CONTRIBUTING.md diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md new file mode 100644 index 0000000..44afc5b --- /dev/null +++ b/CONTRIBUTING.md @@ -0,0 +1 @@ +I will not be accepting PR's on this repository. Feel free to fork and maintain your own version. diff --git a/README.md b/README.md index 3aa2010..432e3a8 100644 --- a/README.md +++ b/README.md @@ -69,6 +69,10 @@ Both Client and API are currently tested through [end-to-end Cypress tests](http - Website: https://getivor.com/ - Skype handle: ivor.reic 💬 +### Contributing + +I will not be accepting PR's on this repository. Feel free to fork and maintain your own version. + ### License [MIT](https://opensource.org/licenses/MIT) From 190dfcd9dc62189a2852acf8e9e7869178a8008c Mon Sep 17 00:00:00 2001 From: ireic Date: Wed, 29 Jan 2020 03:27:09 +0100 Subject: [PATCH 2/3] Readme formatting --- README.md | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/README.md b/README.md index 432e3a8..4d42eb5 100644 --- a/README.md +++ b/README.md @@ -64,23 +64,23 @@ Not all components have properly defined [aria attributes](https://developer.moz Both Client and API are currently tested through [end-to-end Cypress tests](https://github.com/oldboyxx/jira_clone/tree/master/client/cypress/integration). That's good enough for a relatively simple application such as this, even if it was a real product. However, as the app grows in complexity, it might be wise to start writing additional unit/integration tests. -### Author: Ivor Reic ✍️ +## Author: Ivor Reic ✍️ - Website: https://getivor.com/ - Skype handle: ivor.reic 💬 -### Contributing +## Contributing I will not be accepting PR's on this repository. Feel free to fork and maintain your own version. -### License +## License [MIT](https://opensource.org/licenses/MIT)
-

+

Visit the live app | View client | View API -

+ From cb7710378de175c2e83ac84f9e71455c22ffb8f2 Mon Sep 17 00:00:00 2001 From: Denis Skiba Date: Sat, 1 Feb 2020 12:10:43 +0700 Subject: [PATCH 3/3] Improve effect There is no need to create function each time when history changes and do not use it. --- client/src/Auth/Authenticate.jsx | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/client/src/Auth/Authenticate.jsx b/client/src/Auth/Authenticate.jsx index cf22672..67ff7d0 100644 --- a/client/src/Auth/Authenticate.jsx +++ b/client/src/Auth/Authenticate.jsx @@ -10,7 +10,8 @@ const Authenticate = () => { const history = useHistory(); useEffect(() => { - const createGuestAccount = async () => { + if (!getStoredAuthToken()) { + const createGuestAccount = async () => { try { const { authToken } = await api.post('/authentication/guest'); storeAuthToken(authToken); @@ -19,8 +20,6 @@ const Authenticate = () => { toast.error(error); } }; - - if (!getStoredAuthToken()) { createGuestAccount(); } }, [history]);