From c91adc7521922fcbc5a81702b2f083515c2e8892 Mon Sep 17 00:00:00 2001
From: k4rli <projects@supa.ee>
Date: Thu, 31 Jul 2025 12:00:13 +0300
Subject: [PATCH] feat(MED-85): fix wrong env variable name

---
 jobs/sync-analysis-groups.ts     | 12 ++++++++----
 jobs/sync-connected-online.ts    |  3 +--
 lib/services/audit.service.ts    |  2 +-
 lib/services/medipost.service.ts |  6 +++---
 4 files changed, 13 insertions(+), 10 deletions(-)

diff --git a/jobs/sync-analysis-groups.ts b/jobs/sync-analysis-groups.ts
index e375248..d7e32d1 100644
--- a/jobs/sync-analysis-groups.ts
+++ b/jobs/sync-analysis-groups.ts
@@ -30,8 +30,7 @@ async function syncData() {
   const password = process.env.MEDIPOST_PASSWORD;
   const sender = process.env.MEDIPOST_MESSAGE_SENDER;
   const supabaseUrl = process.env.NEXT_PUBLIC_SUPABASE_URL;
-  const supabaseServiceRoleKey =
-    process.env.NEXT_PUBLIC_SUPABASE_SERVICE_ROLE_KEY;
+  const supabaseServiceRoleKey = process.env.SUPABASE_SERVICE_ROLE_KEY;
 
   if (
     !baseUrl ||
@@ -68,7 +67,7 @@ async function syncData() {
         }
       : {};
 
-    const { data } = await axios.get(baseUrl, {
+    const { data, status } = await axios.get(baseUrl, {
       params: {
         Action: 'GetPublicMessageList',
         User: user,
@@ -79,11 +78,16 @@ async function syncData() {
       },
     });
 
+    if (!data || status !== 200) {
+      console.error("Failed to get public message list, status: ", status, data);
+      throw new Error('Failed to get public message list');
+    }
+
     if (data.code && data.code !== 0) {
       throw new Error('Failed to get public message list');
     }
 
-    if (!data.messages.length) {
+    if (!data.messages?.length) {
       return supabase.schema('audit').from('sync_entries').insert({
         operation: 'ANALYSES_SYNC',
         comment: 'No new data received',
diff --git a/jobs/sync-connected-online.ts b/jobs/sync-connected-online.ts
index d2ad5c9..4944bb7 100644
--- a/jobs/sync-connected-online.ts
+++ b/jobs/sync-connected-online.ts
@@ -12,8 +12,7 @@ async function syncData() {
 
   const baseUrl = process.env.CONNECTED_ONLINE_URL;
   const supabaseUrl = process.env.NEXT_PUBLIC_SUPABASE_URL;
-  const supabaseServiceRoleKey =
-    process.env.NEXT_PUBLIC_SUPABASE_SERVICE_ROLE_KEY;
+  const supabaseServiceRoleKey = process.env.SUPABASE_SERVICE_ROLE_KEY;
 
   if (!baseUrl || !supabaseUrl || !supabaseServiceRoleKey) {
     throw new Error('Could not access all necessary environment variables');
diff --git a/lib/services/audit.service.ts b/lib/services/audit.service.ts
index 994a25b..5d15548 100644
--- a/lib/services/audit.service.ts
+++ b/lib/services/audit.service.ts
@@ -18,7 +18,7 @@ export default async function logRequestResult(
 ) {
   const supabaseServiceUser = createClient(
     process.env.NEXT_PUBLIC_SUPABASE_URL!,
-    process.env.NEXT_PUBLIC_SUPABASE_SERVICE_ROLE_KEY!,
+    process.env.SUPABASE_SERVICE_ROLE_KEY!,
     {
       auth: {
         persistSession: false,
diff --git a/lib/services/medipost.service.ts b/lib/services/medipost.service.ts
index 775f870..7e25449 100644
--- a/lib/services/medipost.service.ts
+++ b/lib/services/medipost.service.ts
@@ -331,7 +331,7 @@ export async function syncPublicMessage(
 ) {
   const supabase = createCustomClient(
     process.env.NEXT_PUBLIC_SUPABASE_URL!,
-    process.env.NEXT_PUBLIC_SUPABASE_SERVICE_ROLE_KEY!,
+    process.env.SUPABASE_SERVICE_ROLE_KEY!,
     {
       auth: {
         persistSession: false,
@@ -386,7 +386,7 @@ export async function composeOrderXML(
 ) {
   const supabase = createCustomClient(
     process.env.NEXT_PUBLIC_SUPABASE_URL!,
-    process.env.NEXT_PUBLIC_SUPABASE_SERVICE_ROLE_KEY!,
+    process.env.SUPABASE_SERVICE_ROLE_KEY!,
     {
       auth: {
         persistSession: false,
@@ -539,7 +539,7 @@ export async function syncPrivateMessage(
 ) {
   const supabase = createCustomClient(
     process.env.NEXT_PUBLIC_SUPABASE_URL!,
-    process.env.NEXT_PUBLIC_SUPABASE_SERVICE_ROLE_KEY!,
+    process.env.SUPABASE_SERVICE_ROLE_KEY!,
     {
       auth: {
         persistSession: false,