Merge pull request #1 from dskiba/patch-1

Patch 1
This commit is contained in:
Leopere
2020-02-08 10:56:16 -05:00
committed by GitHub
3 changed files with 10 additions and 11 deletions

View File

@@ -1,4 +0,0 @@
# Newcomers will be inducted
Any PR's are welcomed not all will be accepted immediately at least until we get [GOVERNANCE.md](/GOVERNANCE.md) defined clearly in [#3](https://github.com/FauxJira/FauxJira/issues/3).
However, as soon as you contribute a PR I will try and induct you as I would love to recruit people as this won't be my main focus so I'll just meta manage long term.

View File

@@ -64,19 +64,23 @@ Not all components have properly defined [aria attributes](https://developer.moz
Both Client and API are currently tested through [end-to-end Cypress tests](https://github.com/oldboyxx/jira_clone/tree/master/client/cypress/integration). That's good enough for a relatively simple application such as this, even if it was a real product. However, as the app grows in complexity, it might be wise to start writing additional unit/integration tests. Both Client and API are currently tested through [end-to-end Cypress tests](https://github.com/oldboyxx/jira_clone/tree/master/client/cypress/integration). That's good enough for a relatively simple application such as this, even if it was a real product. However, as the app grows in complexity, it might be wise to start writing additional unit/integration tests.
### Author: Ivor Reic ✍️ ## Author: Ivor Reic ✍️
- Website: https://getivor.com/ - Website: https://getivor.com/
- Skype handle: ivor.reic 💬 - Skype handle: ivor.reic 💬
### License ## Contributing
I will not be accepting PR's on this repository. Feel free to fork and maintain your own version.
## License
[MIT](https://opensource.org/licenses/MIT) [MIT](https://opensource.org/licenses/MIT)
<hr> <hr>
<h4> <h3>
<a href="https://jira.ivorreic.com/">Visit the live app</a> | <a href="https://jira.ivorreic.com/">Visit the live app</a> |
<a href="https://github.com/oldboyxx/jira_clone/tree/master/client">View client</a> | <a href="https://github.com/oldboyxx/jira_clone/tree/master/client">View client</a> |
<a href="https://github.com/oldboyxx/jira_clone/tree/master/api">View API</a> <a href="https://github.com/oldboyxx/jira_clone/tree/master/api">View API</a>
</h4> </h3>

View File

@@ -10,7 +10,8 @@ const Authenticate = () => {
const history = useHistory(); const history = useHistory();
useEffect(() => { useEffect(() => {
const createGuestAccount = async () => { if (!getStoredAuthToken()) {
const createGuestAccount = async () => {
try { try {
const { authToken } = await api.post('/authentication/guest'); const { authToken } = await api.post('/authentication/guest');
storeAuthToken(authToken); storeAuthToken(authToken);
@@ -19,8 +20,6 @@ const Authenticate = () => {
toast.error(error); toast.error(error);
} }
}; };
if (!getStoredAuthToken()) {
createGuestAccount(); createGuestAccount();
} }
}, [history]); }, [history]);